Skip to content

[Snyk] Fix for 1 vulnerabilities #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashim21223445 merged 1 commit into from
Nov 19, 2025
Merged

[Snyk] Fix for 1 vulnerabilities #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@vuepress/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@
"css-loader": "^2.1.1",
"esbuild": "0.25.9",
"file-loader": "^3.0.1",
"js-yaml": "^3.13.1",
"js-yaml": "^3.14.2",
"lru-cache": "^5.1.1",
"mini-css-extract-plugin": "0.6.0",
"optimize-css-assets-webpack-plugin": "^5.0.1",
"optimize-css-assets-webpack-plugin": "^6.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to optimize-css-assets-webpack-plugin v6.0.0 introduces a breaking change regarding the required Node.js version. This version of the plugin depends on cssnano@5, which requires Node.js >= 10.13.0. However, this project's package.json specifies "engines": { "node": ">=8.6" } on line 75. This will cause build failures for users on Node.js versions between 8.6 and 10.13.0.

To resolve this, you could:

  1. Update the project's required Node.js version in the engines field to >=10.13.0 if you are dropping support for older Node versions.
  2. Avoid this major upgrade if you need to maintain compatibility with Node.js 8.6+. The vulnerability fix is in js-yaml, so the upgrade of optimize-css-assets-webpack-plugin might not be strictly necessary.

"portfinder": "^1.0.13",
"postcss-loader": "^3.0.0",
"postcss-safe-parser": "^4.0.1",
Expand Down
Loading