Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented May 27, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
rust patch 2024-05-20 -> 2024-05-27

Configuration

📅 Schedule: Branch creation - "before 11am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot enabled auto-merge May 27, 2024 07:47
renovate-approve[bot]
renovate-approve bot previously approved these changes May 27, 2024
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/libs > deer Affects the `deer` crate (library) area/libs > antsi Affects the `antsi` crate (library) area/libs > sarif Affects the `sarif` crate (library) area/apps labels May 27, 2024
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > backend Owned by the @backend team area/tests New or updated tests area/apps > hash-graph labels May 28, 2024
@TimDiekmann TimDiekmann requested a review from indietyp May 28, 2024 08:57
@renovate
Copy link
Contributor Author

renovate bot commented May 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Member

@indietyp indietyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, just some notes, as to why lint changes happened, otherwise LGTM

@@ -1,7 +1,5 @@
//! Web routes for CRU operations on accounts.
#![expect(clippy::str_to_string)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is because of rust-lang/rust-clippy#12780?

#![expect(
unreachable_pub,
clippy::significant_drop_tightening,
clippy::significant_drop_in_scrutinee,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return Err(Report::new(BufferError::EarlyEndOfStream));
}

#[expect(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indietyp
indietyp previously approved these changes May 28, 2024
@github-actions
Copy link
Contributor

Benchmark results

@rust/graph-benches – Integrations

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$1.53 \mathrm{s} \pm 2.90 \mathrm{ms}\left({\color{gray}-0.502 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$31.7 \mathrm{ms} \pm 200 \mathrm{μs}\left({\color{lightgreen}-38.407 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$21.3 \mathrm{ms} \pm 100 \mathrm{μs}\left({\color{gray}0.457 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$74.3 \mathrm{ms} \pm 296 \mathrm{μs}\left({\color{gray}-0.062 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$25.5 \mathrm{ms} \pm 240 \mathrm{μs}\left({\color{gray}-1.040 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$17.5 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{red}6.97 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.7 \mathrm{ms} \pm 173 \mathrm{μs}\left({\color{red}6.73 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.9 \mathrm{ms} \pm 224 \mathrm{μs}\left({\color{gray}-1.425 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.9 \mathrm{ms} \pm 206 \mathrm{μs}\left({\color{gray}0.550 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.7 \mathrm{ms} \pm 186 \mathrm{μs}\left({\color{gray}2.23 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.4 \mathrm{ms} \pm 191 \mathrm{μs}\left({\color{gray}-0.235 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.7 \mathrm{ms} \pm 196 \mathrm{μs}\left({\color{gray}2.53 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$15.9 \mathrm{ms} \pm 177 \mathrm{μs}\left({\color{lightgreen}-37.360 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.8 \mathrm{ms} \pm 213 \mathrm{μs}\left({\color{red}7.84 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$1.99 \mathrm{s} \pm 8.12 \mathrm{ms}\left({\color{gray}0.707 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$1.05 \mathrm{s} \pm 3.82 \mathrm{ms}\left({\color{gray}0.307 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$1.04 \mathrm{s} \pm 7.80 \mathrm{ms}\left({\color{gray}0.563 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$97.7 \mathrm{ms} \pm 714 \mathrm{μs}\left({\color{gray}2.54 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$421 \mathrm{ms} \pm 1.81 \mathrm{ms}\left({\color{gray}2.28 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$60.0 \mathrm{ms} \pm 443 \mathrm{μs}\left({\color{gray}0.693 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$2.84 \mathrm{s} \pm 12.3 \mathrm{ms}\left({\color{gray}0.603 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$969 \mathrm{ms} \pm 4.24 \mathrm{ms}\left({\color{gray}-0.156 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$962 \mathrm{ms} \pm 3.53 \mathrm{ms}\left({\color{gray}-2.667 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$40.2 \mathrm{ms} \pm 250 \mathrm{μs}\left({\color{gray}-1.613 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$354 \mathrm{ms} \pm 1.51 \mathrm{ms}\left({\color{gray}-1.866 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$36.2 \mathrm{ms} \pm 239 \mathrm{μs}\left({\color{gray}-3.192 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.39 \mathrm{ms} \pm 5.21 \mathrm{μs}\left({\color{gray}-0.207 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1000 entities $$4.19 \mathrm{ms} \pm 19.4 \mathrm{μs}\left({\color{red}26.5 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.54 \mathrm{ms} \pm 11.9 \mathrm{μs}\left({\color{gray}-2.086 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.44 \mathrm{ms} \pm 11.8 \mathrm{μs}\left({\color{gray}-1.288 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.5 \mathrm{ms} \pm 131 \mathrm{μs}\left({\color{gray}-1.147 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.45 \mathrm{ms} \pm 13.0 \mathrm{μs}\left({\color{gray}-0.608 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.46 \mathrm{ms} \pm 20.0 \mathrm{μs}\left({\color{gray}-3.866 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.69 \mathrm{ms} \pm 15.3 \mathrm{μs}\left({\color{gray}-0.758 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.49 \mathrm{ms} \pm 12.4 \mathrm{μs}\left({\color{gray}-0.224 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.21 \mathrm{ms} \pm 73.7 \mathrm{μs}\left({\color{lightgreen}-6.472 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.51 \mathrm{ms} \pm 13.5 \mathrm{μs}\left({\color{gray}-0.465 \mathrm{\%}}\right) $$ Flame Graph

@renovate renovate bot added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 4ee6d43 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-graph area/apps area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs > antsi Affects the `antsi` crate (library) area/libs > deer Affects the `deer` crate (library) area/libs > error-stack Affects the `error-stack` crate (library) area/libs > sarif Affects the `sarif` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

3 participants