Update Rust toolchains to nightly-2024-05-27 - #4522
Merged
Merged
Conversation
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
indietyp
requested changes
May 28, 2024
indietyp
left a comment
Member
There was a problem hiding this comment.
one question, just some notes, as to why lint changes happened, otherwise LGTM
| @@ -1,7 +1,5 @@ | |||
| //! Web routes for CRU operations on accounts. | |||
|
|
|||
| #![expect(clippy::str_to_string)] | |||
Member
There was a problem hiding this comment.
I assume this is because of rust-lang/rust-clippy#12780?
| #![expect( | ||
| unreachable_pub, | ||
| clippy::significant_drop_tightening, | ||
| clippy::significant_drop_in_scrutinee, |
Member
| return Err(Report::new(BufferError::EarlyEndOfStream)); | ||
| } | ||
|
|
||
| #[expect( |
Member
There was a problem hiding this comment.
indietyp
previously approved these changes
May 28, 2024
TimDiekmann
approved these changes
May 29, 2024
Contributor
Benchmark results
|
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 50 entities | Flame Graph | |
| entity_by_id | 10 entities | Flame Graph | |
| entity_by_id | 1 entities | Flame Graph | |
| entity_by_id | 25 entities | Flame Graph | |
| entity_by_id | 5 entities | Flame Graph |
representative_read_entity
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1
|
Flame Graph | |
| entity_by_id | entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1
|
Flame Graph |
representative_read_multiple_entities
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| link_by_source_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph | |
| link_by_source_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph | |
| link_by_source_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph | |
| entity_by_property | depths: DT=255, PT=255, ET=255, E=255 | Flame Graph | |
| entity_by_property | depths: DT=2, PT=2, ET=2, E=2 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=2, ET=2, E=2 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=0, ET=0, E=2 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=0, ET=2, E=2 | Flame Graph | |
| entity_by_property | depths: DT=0, PT=0, ET=0, E=0 | Flame Graph |
representative_read_entity_type
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| get_entity_type_by_id | Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579
|
Flame Graph |
scaling_read_entity_linkless
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 1000 entities | Flame Graph | |
| entity_by_id | 100 entities | Flame Graph | |
| entity_by_id | 10 entities | Flame Graph | |
| entity_by_id | 10000 entities | Flame Graph | |
| entity_by_id | 1 entities | Flame Graph |
scaling_read_entity_complete_zero_depth
| Function | Value | Mean | Flame graphs |
|---|---|---|---|
| entity_by_id | 50 entities | Flame Graph | |
| entity_by_id | 10 entities | Flame Graph | |
| entity_by_id | 1 entities | Flame Graph | |
| entity_by_id | 25 entities | Flame Graph | |
| entity_by_id | 5 entities | Flame Graph |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2024-05-20->2024-05-27Configuration
📅 Schedule: Branch creation - "before 11am" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.