add bindings for renderCopyExF, FRect, FPoint #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm it looks like the Travis CI build is using SDL 2.0.6, but this branch requires SDL 2.0.10 or later. |
|
Please rebase the PR. The new CI should have fresh SDL. |
Thanks, the CI checks look good now. Also tested this locally with https://github.com/incoherentsoftware/defect-process which uses the branch and it seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDL_RenderCopyExF() function is undocumented but needed to draw textures at floating point coordinates, this is useful to avoid rounding issues when rendering. It was added in libsdl-org/SDL@8340b0f (Oct 22, 2018) and the interface seems to have been stable since?
Tested this out manually on Windows 10 (64-bit), Arch Linux (x86-64), and macOS 10.13.6.