SDL.Audio: Fix openAudioDevice Changeable check #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`foldChangeable` expects the value for Mandate as its first argument and the value for Desire as its second, but `changes` in `openAudioDevice` had them reversed. Swap them.
dpwiz
approved these changes
Jun 19, 2021
|
Thanks, and sorry this took so long to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple bugfix.
foldChangeableexpects the value forMandateas its first argument and the value forDesireas its second, butchangesinopenAudioDevicehad them reversed, so this simply swaps the two values there.I noticed this when trying to run
audio-example. I use JACK as my SDL audio driver; JACK expects samples as 32-bit floats. Under those circumstances, SDL will set the audio format toAUDIO_F32unless you insist otherwise. As written,audio-examplewas erroring out with "unsupported audio format" as a result of this, becauseMandate Signed16BitNativeAudiowas actually settingSDL_AUDIO_ALLOW_FORMAT_CHANGE. With this fix,audio-exampleruns properly in my environment.