Future-proof against potential Prelude.foldl' #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phadej shall I rather make all imports from |
That would be nice. |
|
Done. |
phadej
reviewed
Jun 12, 2023
src/Data/Text/Short/Internal.hs
Outdated
| @@ -106,6 +106,12 @@ module Data.Text.Short.Internal | |||
| , isValidUtf8 | |||
| ) where | |||
|
|
|||
| import Prelude | |||
| (Bool(..), Ordering(..), Int, Char, String, Maybe(..), IO, Eq, Ord, Num, Read, | |||
| Show, Monoid, ($), ($!), (.), (==), (/=), (+), (*), (-), (>>), (<=), (<), (>), (>=), | |||
There was a problem hiding this comment.
import Data.Monoid (Monoid, mempty, mconcat)as separate import.
There was a problem hiding this comment.
@phadej done, thanks.
|
@phadej anything else you'd like me to do here? CI failures seem unrelated. |
|
No. I was waiting (and kind of still do) for |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See haskell/core-libraries-committee#167
This is, of course, a bit speculative at the moment, but given that the change does not involve CPP, it should not hurt to merge it early to simplify further impact assessment.