Parse error recovery and incrementality for GHC #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Feb 3, 2024
| There are a couple of stretch goals: | ||
|
|
||
| * `happy` could further be improved to pass a closure of its | ||
| parse state to reduction actions, so as to enable incremental parsing. |
| * `happy` could further be improved to pass a closure of its | ||
| parse state to reduction actions, so as to enable incremental parsing. | ||
| * Improve `happy` so that it provides a convenient and encapsulated way to | ||
| introspect the LALR item stack, for example to identify bracketing |
| productions such as `'(' expr . ')'` in order to report mismatched brackets. | ||
| There is a [hacky GHC Merge Request](https://gitlab.haskell.org/ghc/ghc/-/merge_requests/4711) | ||
| that tries to achieve as much without buy in from happy. | ||
| * Improve `happy`s code base, which by now is over 25 years old. |
There was a problem hiding this comment.
Might be helpful to identify a couple of concrete things: just "modernisation", or comments, or tests, or what?
There was a problem hiding this comment.
Indeed it is rather hard to spell out what could make a substantial improvment. Certainly it appears that the modularisation effort has left happy in a rather rough stage. See #183.
|
LGTM, thanks! I'm going to go ahead and merge this so that it's listed on the site before I submit the GSoC application. Feel free to open another PR if you want to make any changes. |
|
Thanks! I addressed Michael's feedback in #183. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.