-
Notifications
You must be signed in to change notification settings - Fork 85
Add some hashed operations from classes that cannot be implemented #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some hashed operations from classes that cannot be implemented #122
Conversation
5742270
to
e0ac463
Compare
traverseHashed f (Hashed a _) = fmap hashed (f a) | ||
|
||
-- | 'Hashed' cannot be 'Monad' | ||
joinHashed :: Hashed (Hashed a) -> Hashed a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one feels a bit odd. Do you have an example of how you would use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't know, added it for "completeness". Not insisting on it to be included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed joinHashed
e0ac463
to
31d2157
Compare
31d2157
to
e19f0ee
Compare
rebased |
6f5b1b3
to
7910f69
Compare
7910f69
to
76b01e9
Compare
@phadej: Sadly, fixing the tests won't be easy because of the reasons I mention in #124 (comment). |
@RyanGlScott well, the tests are run with newer GHCs at least, which is better than nothing. As you can see, I found an issues with in the library itself, when build on older GHC (e.g. Now the travis is finally green, with tests run with GHC7.10 and GHC8.0. |
@phadej, I totally agree that having green Travis builds is a must. Although at the moment, we're cheating a bit by selectively disabling tests, aren't we? It would be great if you could run the Our task would probably be a lot simpler if |
@RyanGlScott I'd rather fix |
If you can fix the issue by depending on a newer version of |
@RyanGlScott, will do, but separately. |
Especially
traverseHashed
which is aLens (Hashed a) (Hashed b) a b
can prove to be useful (there could beIso
, but we'd need aprofunctors
for that, which we cannot have here).