Skip to content

Build also with stack on travis (benchmarks) #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2016

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 13, 2016

No description provided.

@hvr
Copy link
Member

hvr commented May 13, 2016

sadly this results in less readable travis log-output as you can't collapse the sections anymore

@phadej
Copy link
Collaborator Author

phadej commented May 13, 2016

@hvr, that's true :(

@phadej
Copy link
Collaborator Author

phadej commented May 13, 2016

Alternatively we could merge benchmarks into aeson package, if there aren't really good reason why they are separate package?

@bergmark
Copy link
Collaborator

Can't, the benchmarks have dependencies like statistics that depend on aeson

@phadej phadej force-pushed the stack-travis branch 3 times, most recently from bb4b772 to 6ba69cf Compare May 13, 2016 15:49
@phadej
Copy link
Collaborator Author

phadej commented May 13, 2016

finally green

@hvr
Copy link
Member

hvr commented May 13, 2016

@bergmark re cyclic deps, see haskell/cabal#3422

@mgsloan
Copy link

mgsloan commented May 14, 2016

Stack has actually supported cyclic deps for most of its existence, though it gets a little dicey with older Cabals due to haskell/cabal#2870 . Currently it only works with tests and benchmarks, and not executables, due to haskell/cabal#2780 . We need to add some code to conditionally lift that restriction if using a new enough Cabal.

@bergmark bergmark merged commit 52460c6 into haskell:master May 22, 2016
@phadej phadej deleted the stack-travis branch June 9, 2016 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants