-
Notifications
You must be signed in to change notification settings - Fork 711
PackageDescription.buildDepends should be nuked #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just for clarification, in the current documentation there is discussion about removing the |
That's a doc bug, the Haddock comment is being associated with the wrong field. |
Signed-off-by: Edward Z. Yang <[email protected]>
Tentative fix in #4265 -- maybe breaking changes are good for 2.0? Will elaborate later. |
Fixes haskell#2066 -- targetBuildDepends :: [LibDependency] -- buildDepends is just an accessor function, not a field -- buildDependencies function is unneeded Not sure about which type should have the (not)ThisPackageVersion function Also need to update some comments. Everything builds, however.
Fixes haskell#2066 -- targetBuildDepends :: [LibDependency] -- buildDepends is just an accessor function, not a field -- buildDependencies function is unneeded Not sure about which type should have the (not)ThisPackageVersion function Also need to update some comments. Everything builds, however.
- Post flag-solving, replace buildDepends with solved dependencies. - Only collect buildDepends from enabled components when configuring. Might need to change a few other `buildDepends` too?
- Post flag-solving, replace buildDepends with solved dependencies. - Only collect buildDepends from enabled components when configuring. Might need to change a few other `buildDepends` too?
- Post flag-solving, replace buildDepends with solved dependencies. - Only collect buildDepends from enabled components when configuring. Doesn't seem to be a need to change other `buildDepends` calls too.
- Post flag-solving, replace buildDepends with solved dependencies. - In most cases, just collect the build-depends of *enabled* components. B4ut in a few, we have no enable spec on hand and must collect them all
- Post flag-solving, replace buildDepends with solved dependencies. - In most cases, just collect the build-depends of *enabled* components. B4ut in a few, we have no enable spec on hand and must collect them all
- Post flag-solving, replace buildDepends with solved dependencies. - In most cases, just collect the build-depends of *enabled* components. B4ut in a few, we have no enable spec on hand and must collect them all
- Post flag-solving, replace buildDepends with solved dependencies. - In most cases, just collect the build-depends of *enabled* components. B4ut in a few, we have no enable spec on hand and must collect them all
- Post flag-solving, replace buildDepends with solved dependencies. - In most cases, just collect the build-depends of *enabled* components. B4ut in a few, we have no enable spec on hand and must collect them all
- Post flag-solving, replace buildDepends with solved dependencies. - In most cases, just collect the build-depends of *enabled* components. B4ut in a few, we have no enable spec on hand and must collect them all
Fix #2066: buildDepends is just an accessor function, not a field
It is a vestige of backwards-compatibility and all build-depends should be put in components.
The text was updated successfully, but these errors were encountered: