Skip to content

PackageDescription.buildDepends should be nuked #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang opened this issue Aug 28, 2014 · 3 comments
Closed

PackageDescription.buildDepends should be nuked #2066

ezyang opened this issue Aug 28, 2014 · 3 comments
Labels
Cabal: other type: refactor
Milestone
⊥

Comments

@ezyang
Copy link
Contributor

ezyang commented Aug 28, 2014

It is a vestige of backwards-compatibility and all build-depends should be put in components.
@ezyang ezyang mentioned this issue Feb 10, 2015
Open
@ttuegel ttuegel added this to the Cabal-1.24 milestone Apr 24, 2015
@dylex
Copy link

dylex commented Aug 10, 2015

Just for clarification, in the current documentation there is discussion about removing the customFieldsPD field that points to this issue, but mainly seems to be discussing the buildDepends field. Is this comment just misplaced, or will this change affect customFieldsPD as well?

@ezyang
Copy link
Contributor Author

ezyang commented Dec 21, 2015

That's a doc bug, the Haddock comment is being associated with the wrong field.

@23Skidoo 23Skidoo modified the milestones: Cabal 1.24, Cabal 1.26 Feb 21, 2016
@phadej phadej mentioned this issue Aug 2, 2016
Merged
ezyang added a commit to ezyang/cabal that referenced this issue Aug 2, 2016
@ezyang
Link to haskell#2066.
73c471d 
Signed-off-by: Edward Z. Yang <[email protected]>
@ezyang ezyang modified the milestones: Cabal 2.0, ⊥ Sep 6, 2016
@Ericson2314
Copy link
Collaborator

Ericson2314 commented Feb 24, 2017 •
edited
Loading

Tentative fix in #4265 -- maybe breaking changes are good for 2.0? Will elaborate later.

Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Mar 1, 2017
@Ericson2314
Clean up "build-depends"-related fields
01131a4 
Fixes haskell#2066

 -- targetBuildDepends :: [LibDependency]
 -- buildDepends is just an accessor function, not a field
 -- buildDependencies function is unneeded

Not sure about which type should have the (not)ThisPackageVersion function
Also need to update some comments. Everything builds, however.
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Mar 3, 2017
@Ericson2314
Clean up "build-depends"-related fields
52cc300 
Fixes haskell#2066

 -- targetBuildDepends :: [LibDependency]
 -- buildDepends is just an accessor function, not a field
 -- buildDependencies function is unneeded

Not sure about which type should have the (not)ThisPackageVersion function
Also need to update some comments. Everything builds, however.
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Mar 9, 2017
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
be84f10 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - Only collect buildDepends from enabled components when configuring.
   Might need to change a few other `buildDepends` too?
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Mar 9, 2017
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
591c0a6 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - Only collect buildDepends from enabled components when configuring.
   Might need to change a few other `buildDepends` too?
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Mar 9, 2017
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
4ffcea7 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - Only collect buildDepends from enabled components when configuring.
   Doesn't seem to be a need to change other `buildDepends` calls too.
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Mar 9, 2017
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
d540a69 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - In most cases, just collect the build-depends of *enabled* components.
   B4ut in a few, we have no enable spec on hand and must collect them
   all
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Apr 4, 2017
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
68d89e5 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - In most cases, just collect the build-depends of *enabled* components.
   B4ut in a few, we have no enable spec on hand and must collect them
   all
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Apr 27, 2017
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
4aeeb7b 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - In most cases, just collect the build-depends of *enabled* components.
   B4ut in a few, we have no enable spec on hand and must collect them
   all
@23Skidoo 23Skidoo mentioned this issue Dec 12, 2017
Closed
kmicklas pushed a commit to kmicklas/cabal that referenced this issue Jan 26, 2018
@Ericson2314 @kmicklas
Fix haskell#2066: buildDepends is just an accessor function, not a field
8939279 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - In most cases, just collect the build-depends of *enabled* components.
   B4ut in a few, we have no enable spec on hand and must collect them
   all
@Ericson2314 Ericson2314 mentioned this issue Jan 27, 2018
Closed
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Jan 30, 2018
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
9333124 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - In most cases, just collect the build-depends of *enabled* components.
   B4ut in a few, we have no enable spec on hand and must collect them
   all
Ericson2314 added a commit to Ericson2314/cabal that referenced this issue Jan 31, 2018
@Ericson2314
Fix haskell#2066: buildDepends is just an accessor function, not a field
d414efb 
 - Post flag-solving, replace buildDepends with solved dependencies.

 - In most cases, just collect the build-depends of *enabled* components.
   B4ut in a few, we have no enable spec on hand and must collect them
   all
Ericson2314 added a commit that referenced this issue Feb 2, 2018
@Ericson2314
Merge pull request #4383 from Ericson2314/no-legacy-build-depends
ea75854 
Fix #2066: buildDepends is just an accessor function, not a field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cabal: other type: refactor
Projects
None yet
Milestone
⊥
Development

No branches or pull requests
5 participants
@ezyang @23Skidoo @dylex @ttuegel @Ericson2314