Skip to content

[nix-local-build] Packages without tests should not considered --enable-tests as part of configuration #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ezyang opened this issue Apr 14, 2016 · 1 comment

Comments

@ezyang
Copy link
Contributor

ezyang commented Apr 14, 2016

Steps to reproduce:

  1. Create a Cabal package with no test suite
  2. cabal new-build
  3. cabal new-build --enable-tests

Expected behavior: Cabal reports nothing to do

Actual behavior: Cabal decides to rebuild the package, because configuration has changed

CC @dcoutts

@ezyang
Copy link
Contributor Author

ezyang commented Apr 14, 2016

I was going to try to fix this myself, but after having reviewed the ProjectPlanning code related to tests, I must admit I have no idea what is going on. There is some logic about "sticky flags" and I don't understand how this interacts with @dcoutt's claims here #3316 (comment) :

The only time you really need to specify --enable-tests is if the solver was not able to optimistically enable the testsuite.

So why do we need the extra stickiness?

UPDATE: I understand what is going on, writing a comment for #3316.

ezyang added a commit to ezyang/cabal that referenced this issue Apr 15, 2016
@ezyang ezyang closed this as completed in f0fdf6e Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant