-
Notifications
You must be signed in to change notification settings - Fork 725
Print out which project file we're using by default (fix #8519) #10507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Converting to a draft because of spurious changes like https://github.com/haskell/cabal/pull/10507/files#diff-d6f32a6a398cc85df21df74b2a260427387c0ea52d96987e49551137d466d92fL7 Will see what CI has to say. |
|
I bet it's because the |
|
I gave up on making that work when I was bisecting an issue and wanted to streamline validate a bit. |
ddc9843 to
ab8d50c
Compare
|
Okay, fixed by running with the in-tree Cabal: |
|
I'll put the label requesting reviews after CI is happy. |
ab8d50c to
321aa6e
Compare
321aa6e to
2011fc6
Compare
|
CI is green now. I'd like this to be considered for 3.14.1 @Kleidukos. |
2011fc6 to
74579bd
Compare
|
@Kleidukos @Mikolaj @ffaf1 I'd appreciate a review for this one. I'd even hope we can get it into 3.14.1. Over the years, many people have tripped over the default behavior of searching project files, and the patch could probably save some of them from it. (The CI was green but I just pushed a changelog file, so it's rebuilding again...) |
Mikolaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good decision. And well tested. :)
|
Thanks! Since it's been up for 5 days, I consider the chill out period passed and apply the label manually in the interest of getting this merged in time for 3.14.1 (the final decision about addition to 3.14.1 is up to Hécate of course). |
Before it's only printed under `-v`.
74579bd to
a6082fc
Compare
|
@mergify backport 3.14 |
✅ Backports have been createdDetails
|
Attempting to resurrect #8617
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR: