-
Notifications
You must be signed in to change notification settings - Fork 710
Create noindex.cache
if missing
#10730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf56870
to
7a81f34
Compare
30b8320
to
833cc77
Compare
833cc77
to
41ff289
Compare
34cd537
to
e354659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. Would there be an easy way to add tests?
CI fails with what seems to be a simple compilation error:
Is @jasagredo available to fix it or should we find a volunteer? I optimistically mark it as desirable for the next 3.14 release. |
@jasagredo may surprise us in a pleasant way, but I know he's busy, so let's find a volunteer. Anybody? |
e354659
to
ca1ed94
Compare
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should update or rebase your pull request manually. If you want to requeue this pull request, you can post a |
ca1ed94
to
2528f73
Compare
@mergify backport 3.14 |
✅ Backports have been created
|
Backport #10730: Create `noindex.cache` if missing
Fixes #9891 by creating the file if it is missing.
Depends on #10728
QA
This will work on Linux:
For Windows, the path has to be un-cygwinize and prepended by
//./
as described in #10728.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)