Default package name and all targets for REPL#11452
Open
philderbeast wants to merge 8 commits intohaskell:masterfrom
Open
Default package name and all targets for REPL#11452philderbeast wants to merge 8 commits intohaskell:masterfrom
philderbeast wants to merge 8 commits intohaskell:masterfrom
Conversation
6 tasks
Collaborator
Author
|
Relevant unresolved review comment from #10684.
|
philderbeast
force-pushed
the
fix/repl-retarget
branch
5 times, most recently
from
03507f5 to
ca9dc9b
Compare
philderbeast
force-pushed
the
fix/repl-retarget
branch
4 times, most recently
from
5667d09 to
047b4e3
Compare
philderbeast
commented
Jan 22, 2026
| -- ^ Global flags. | ||
| -> CurrentCommand | ||
| -- ^ Current Command (usually for error reporting). | ||
| -> (TargetContext -> ProjectBaseContext -> [TargetSelector] -> IO b) |
Collaborator
Author
There was a problem hiding this comment.
If we can flip the argument order here in withContextAndSelectors, a refactor, then I'd like to change TargetsAction too dropping its ProjectBaseContext argument.
diff --git a/cabal-install/src/Distribution/Client/ScriptUtils.hs b/cabal-install/src/Distribution/Client/ScriptUtils.hs
index 1c78d537c..08921b1e3 100644
--- a/cabal-install/src/Distribution/Client/ScriptUtils.hs
+++ b/cabal-install/src/Distribution/Client/ScriptUtils.hs
@@ -289,7 +289,7 @@ withContextAndSelectors
-- ^ Global flags.
-> CurrentCommand
-- ^ Current Command (usually for error reporting).
- -> (TargetContext -> ProjectBaseContext -> [TargetSelector] -> IO b)
+ -> (ProjectBaseContext -> TargetContext -> [TargetSelector] -> IO b)
-- ^ The body of your command action.
-> IO b
withContextAndSelectors verbosity noTargets kind flags@NixStyleFlags{..} targetStrings globalFlags cmd act =
Collaborator
There was a problem hiding this comment.
Perhaps that should be a subsequent PR?
philderbeast
commented
Jan 22, 2026
Comment on lines
+406
to
+407
| ctx | ||
| ((baseCtx, multiReplEnabled), targetSelectors) = do |
Collaborator
Author
There was a problem hiding this comment.
It looks to me like ctx and baseCtx are the same.
Collaborator
Author
@mpickering, can these be constructed as |
geekosaur
approved these changes
Jan 22, 2026
| -- ^ Global flags. | ||
| -> CurrentCommand | ||
| -- ^ Current Command (usually for error reporting). | ||
| -> (TargetContext -> ProjectBaseContext -> [TargetSelector] -> IO b) |
Collaborator
There was a problem hiding this comment.
Perhaps that should be a subsequent PR?
philderbeast
force-pushed
the
fix/repl-retarget
branch
from
047b4e3 to
c472188
Compare
- Show packages when no --project-file is given - Handle the case with no packages in the project - Add a changelog - Add tests - Satisfy hlint - Satisfy fourmolu - Don't need a target when there is one package - Adjust target strings for sole package - Add alt.project tests for ReplOptions - Silence the 1st withCtx call's verbosity - Don't repeat configuration is affected by - Satisfy whitespace - Fixups after rebase - Remove punct variable - Review comment changes - Comma with but joining indep' clauses - Use single package - Update tests, adding more assertions - Improve test descriptions - Mention [package:][ctype:]component - Don't repeat [package:][ctype:]component - Lift validatedTargets, rename r as replFlags - Don't use -XRecordWildCards for configFlags - Add a one.project one pkg test - Remove target string manipulation - Make reportProjectNoTarget a function - Redo ReplProjectTarget tests - Redo ReplProjectNoneTarget tests - Satisfy fix-whitespace - Error whether or not project has packages - Guard against triggering an assertion if targets are null - Skip if Windows - Repl commands mentioning the fake-package - Don't yet automatically pick only choice - Autopick the one package - Split ReplProjectTarget test - Add tests for repl all target - Default target to all with multireplh - Add a retargetting message - Add test for default "all" target when multirepl - Add type synonym TargetPick - Add targetedRepl - RejectNoTargets if target strings not null - Guard against infinite retargeting & null pkgs - Redo the changelog. - Remove TargetPick type synonym Co-Authored-By: brandon s allbery kf8nh <allbery.b@gmail.com>
- Update expected fake-package-0 message
- Move only deps check - Add type synonym, Repl t a
philderbeast
force-pushed
the
fix/repl-retarget
branch
from
c472188 to
7226592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11451. A follow on from #10684 that I closed because its changelog entry was already committed with #11237. This is the behaviour change of #10684 that was not included with #11237.
Uses existing tests. Some of these no longer fail if no target is supplied.
significance: significantin the changelog file.