Use a non-default build dir when building add-source deps. #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
23Skidoo
added a commit
that referenced
this pull request
May 5, 2013
Use a non-default build dir when building add-source deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1281.
I decided against using
.cabal-sandbox/dist/$PKGIDsince we can have several add-source deps with a single$PKGID. Although that can probably be fixed by deleting the build dir when adding an add-source dep with an already-existing package id, there is another complication - when doinginstall --only-dependencies, there is no way to distinguish add-source deps (for which we want to cache the build dir under.cabal-sandbox) from regular ones (for which we likely don't).