Conditionally omit TemplateHaskell from set of supported extensions
#2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This emulates what GHC>=8 will do on its own for older GHC versions. This is particularly useful in combination with haskell#2644 allowing the solver to toggle flags depending on the availability of `-XTemplateHaskell`. For instance, cross-compilers and/or unregisterised GHC builds often don't have TemplateHaskell support. Having support for toggling flags based on availability of `-XTemplateHaskell` allows `cabal` to support such environments with less manual intervention.
|
See also https://phabricator.haskell.org/D1484 /cc @bgamari |
|
Would be nice to have a package test for that... |
|
LGTM. @phadej |
23Skidoo
added a commit
that referenced
this pull request
Nov 17, 2015
Conditionally omit `TemplateHaskell` from set of supported extensions
|
@23Skidoo Ah indeed. Pity. Have to live without test then. |
hvr
pushed a commit
to ghc/ghc
that referenced
this pull request
Nov 18, 2015
`-XTemplateHaskell` requires GHCi; don't show it in `--supported-extensions` if it's not supported. Together with haskell/cabal#2644 this allows to finally fix a long-standing annoyance in cabal of not being able to detect availability of TH in build-plans. Fixes #11102 See also haskell/cabal#2930 which provides emulation of this feature for older GHCs. Reviewed By: bgamari Differential Revision: https://phabricator.haskell.org/D1484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This emulates what GHC>=8 will do on its own for older GHC versions.
This is particularly useful in combination with #2644 allowing the
solver to toggle flags depending on the availability of
-XTemplateHaskell.For instance, cross-compilers and/or unregisterised GHC builds often
don't have TemplateHaskell support. Having support for toggling flags
based on availability of
-XTemplateHaskellallowscabaltosupport such environments with less manual intervention.