Add flag to disable Cabal package tests that use shared libraries #3146
Conversation
The flag --skip-shared-library-tests allows the tests to run when shared libraries are unavailable, such as during the AppVeyor build.
| @@ -14,6 +14,7 @@ build_script: | |||
| - Setup configure --user --ghc-option=-Werror --enable-tests | |||
| - Setup build | |||
| - Setup test unit-tests --show-details=streaming | |||
| # - Setup test package-tests --show-details=streaming --test-options=--skip-shared-library-tests | |||
There was a problem hiding this comment.
I added it because I thought we could run the package tests soon. The only failure is #3147.
Add flag to disable Cabal package tests that use shared libraries
|
Merged, thanks! |
|
Thanks! I'll update HACKING.md and/or the test readme. |
| @@ -25,9 +27,12 @@ import Distribution.Verbosity (normal, flagToVerbosity) | |||
| import Distribution.ReadE (readEOrFail) | |||
|
|
|||
| import Control.Exception | |||
| import Data.Typeable (Proxy(..), Typeable) | |||
There was a problem hiding this comment.
BTW, this broke the build on GHC <= 7.6. I changed this line to import Data.Proxy instead and added a dependency on tagged.
There was a problem hiding this comment.
Thanks. I was just looking into that.
|
This is late to the party, but the prevailing style for this test suite has been to use environment variables to pass everything in. I guess now that we've added support for extra command line arguments we should make all of the other parameters support it too. |
|
I chose a flag because I wanted the parameter to be more explicit. An environment variable would also work. Should I change it, for consistency? |
|
I don't think we need to change it, but as @ezyang says, it'd be nice if the other parameters could be also passed via the command line. |
The flag
--skip-shared-library-testsallows the tests to run when shared libraries are unavailable, such as during the AppVeyor build.This is a step towards #3112. I wanted to minimize the changes to existing tests but also make it easy to see what tests are being skipped. I'm not sure if this is the best solution.