Extend cabal list cmd #3202
Closed
Extend cabal list cmd #3202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements one solution to haskell#879. Extends the cabal list command (as described in haskell#879): generalizing the idea of listing the license field to listing multiple, arbitrary fields of the dependent packages.
| then notice verbosity "No matches found." | ||
| else putStr $ unlines (map showPackageSummaryInfo matches) | ||
| list verbosity packageDBs repoCtxt comp conf listFlags pats = do | ||
| unless (simpleOutput || null fields) $ |
There was a problem hiding this comment.
So just --field=foo --simple-output is allowed, even though it has no effect? From the error message it looks like the test should be when (not.null fields && (not simpleOutput || not onlyDependencies)) $ die "...".
|
Whats the status of this PR? |
|
Looks like the author never addressed the review points. I'm inclined to close, but anyone is willing to take over and finish the patches. |
|
We should probably close. There's a different path to some of this now through the plan.json stuff, and arguably that can be extended to the rest. I'm closing now, but if anyone objects speak up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a solution to #879 by extending the cabal 'list' command with a --dependencies option.
I generalize the idea of listing the license field to listing multiple, arbitrary fields (a --field option) of the packages that are dependencies.
This doesn't address the extraction of License files (as discussed in #879).