Change dist-newstyle layout from build/pid to build/ipkgid. #3652
Conversation
Sorry, all you folks who have finger-macroed dist-newstyle/build/pkg-1.0; the format will now be dist-newstyle/build/pkg-1.0-inplace (or perhaps even further mangled.) Although "inplace" is seemingly redundant, it won't be when we build components individually (build/pkg-1.0-inplace-exename) where each component needs a separate dist-directory. If we change our inplace identifiers to be more detailed (see haskell#3343) then it permits inplace builds to handle all situations where package identifiers do not sufficiently disambiguate. Signed-off-by: Edward Z. Yang <[email protected]>
|
@ezyang, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dcoutts and @BardurArantsson to be potential reviewers |
|
We should think a bit about how to delete stuff that's no longer needed. We already have this problem when changing version, and it's only going to get worse with this patch and with other distinctions we'd like to make (e.g. building the same package at the same time with two compilers) |
|
Code looks fine, but the commit message should mention that the "-inplace" bit refers only to local source dir packages, and in general one gets "pkgid-1.0-$hash". The change probably also warrants a line in the changelog. |
|
Punting this patch in favor of a better one, which will qualify by compiler and arch as well. |
Sorry, all you folks who have finger-macroed
dist-newstyle/build/pkg-1.0; the format will now
be dist-newstyle/build/pkg-1.0-inplace (or perhaps
even further mangled.) Although "inplace" is seemingly
redundant, it won't be when we build components individually
(build/pkg-1.0-inplace-exename) where each component needs
a separate dist-directory. If we change our inplace
identifiers to be more detailed (see #3343) then it
permits inplace builds to handle all situations where
package identifiers do not sufficiently disambiguate.
Signed-off-by: Edward Z. Yang [email protected]