Skip to content

Pass on -v0 to GHC. #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2016
Merged

Pass on -v0 to GHC. #3671

merged 1 commit into from
Aug 6, 2016

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 5, 2016

Signed-off-by: Edward Z. Yang [email protected]

@mention-bot
Copy link

@ezyang, thanks for your PR! By analyzing the annotation information on this pull request, we identified @23Skidoo, @dcoutts and @luite to be potential reviewers

@@ -272,8 +273,9 @@ componentGhcOptions :: Verbosity -> LocalBuildInfo
-> GhcOptions
componentGhcOptions _verbosity lbi bi clbi odir =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/_verbosity/verbosity/

@23Skidoo
Copy link
Member

23Skidoo commented Aug 5, 2016

LGTM.

@23Skidoo
Copy link
Member

23Skidoo commented Aug 5, 2016

Related: #3540.

@23Skidoo
Copy link
Member

23Skidoo commented Aug 6, 2016

Still fails to compile:

Distribution/Client/SetupWrapper.hs:629:39: Not in scope: `toFlag'

Distribution/Client/SetupWrapper.hs:629:61: Not in scope: `normal'

Signed-off-by: Edward Z. Yang <[email protected]>
@ezyang ezyang merged commit a92bfc8 into haskell:master Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants