Allocate different ComponentId for lib and exe. #4015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the old code, we assumed that only libraries could get installed, but with executable dependencies this is no longer true. Handle it correctly. This bug caused cycles in the elaborated install plan which could cause dependency closure to fail, resulting in weird errors. Fixes haskell#3996. Signed-off-by: Edward Z. Yang <[email protected]>
|
Thanks! This fixed the problem for me. |
|
Sorry, prematurely merged this by mistake. Reverted in 211776b. |
|
And now because GitHub is dumb I guess I have to open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old code, we assumed that only libraries could get
installed, but with executable dependencies this is no
longer true. Handle it correctly.
This bug caused cycles in the elaborated install plan which
could cause dependency closure to fail, resulting in
weird errors.
Fixes #3996.
CC @dcoutts
Signed-off-by: Edward Z. Yang [email protected]