Qualified constraints (issue #3502) part 2 #4228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 12, 2017 12:25
I also removed 'unqualified' from PackagePath.hs and replaced all uses of it with 'scopeToplevel'. The meaning is identical, however 'scopeToplevel' is a less confusing name.
Prefixed all constructors of Qualifier with 'Qual' to make it easier to grep them. Renamed 'Unqualified' to 'Toplevel'.
ghost
mentioned this pull request
|
/cc @grayjay |
grayjay
approved these changes
Jan 13, 2017
| @@ -150,7 +150,7 @@ projectFreezeConstraints plan = | |||
| versionConstraints :: Map PackageName [(UserConstraint, ConstraintSource)] | |||
| versionConstraints = | |||
| Map.mapWithKey | |||
| (\p v -> [(UserConstraint UserUnqualified p (PackagePropertyVersion v), | |||
| (\p v -> [(UserConstraint UserToplevel p (PackagePropertyVersion v), | |||
There was a problem hiding this comment.
That's a lot clearer. Thanks for renaming the constructors.
| ++ "either a version range, 'installed', 'source' or flags" | ||
| "expected a (possibly qualified) package name followed by a " ++ | ||
| "constraint, which is either a version range, 'installed', " ++ | ||
| "'source', 'test', 'bench', or flags" |
| @@ -361,7 +361,7 @@ dontUpgradeNonUpgradeablePackages params = | |||
| where | |||
| extraConstraints = | |||
| [ LabeledPackageConstraint | |||
| (PackageConstraint (unqualified pkgname) PackagePropertyInstalled) | |||
| (PackageConstraint (scopeToplevel pkgname) PackagePropertyInstalled) | |||
There was a problem hiding this comment.
The non-upgradable package constraints can use ScopeAnyQualifier now.
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some further refactoring to address issues discussed in PR #4219