Unknown build-tools are looked up on the PATH -- fix and test #4260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we resolve those internally, the pkg name and version bound are both irrelevant
This is a bug from `first build-tool-depends` PR: haskell#4104 Also, remove TODO about factoring things out. The exact set of deps filter here is no longer so globally relevant, and `Distribution.Simple.BuildToolDepends` exposes better filters which are.
Ericson2314
changed the title
|
Windows failure seems to be genuine. |
Ericson2314
force-pushed
the
build-tools-path
branch
from
b06b641 to
0ccf26d
Compare
|
@23Skidoo yeah its going to take a couple of pushes. Sorry I should have a WIP, I opened this to get CI. |
Ericson2314
changed the title
Should we stick this in the testing prelude too?
|
Ok, I think Travis is going to pass. Is this windows failure meaningful? |
Ericson2314
changed the title
|
Only failure is a timeout---restarted but out of OSX compute for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers most of what was completed from #4241