Fix #4217 #4262
Merged
Fix #4217 #4262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to instead change the solver to route the used components through (baby steps towards per-component solving), rather than reconstruct it post-hoc from the Package Description, but this gets the job done for now.
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezyang, @dcoutts and @23Skidoo to be potential reviewers. |
|
What problems are you having running the test suite? (Are you passing |
Ericson2314
force-pushed
the
needed-exes-only
branch
3 times, most recently
from
36fcb42 to
5423a6b
Compare
The executable is unused so it shouldn't need to be built and cause problems. Also, convert the test to use the testsuite
Ericson2314
force-pushed
the
needed-exes-only
branch
from
5423a6b to
0ed1909
Compare
|
Arg---forgot to pull before |
|
Only a timeout on Travis. |
|
OK LGTM, CI failures seem spurious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4241
I'd like to instead change the solver to route the used components through (baby steps towards per-component solving), rather than reconstruct it post-hoc from the Package Description, but this gets the job done for now.
FYI, I have bad luck running the cabal-install tests locally---so I'm just going to rely on CI for the moment.