Further compact build profile output in new-build #4620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23Skidoo
reviewed
Jul 21, 2017
| showBuildProfile = "Build profile: " ++ unwords [ | ||
| "-w " ++ (showCompilerId . pkgConfigCompiler) elaboratedShared, | ||
| "-O" ++ (case packageConfigOptimization of | ||
| Setup.Flag NoOptimisation -> "0" |
There was a problem hiding this comment.
Don't we already have a utility function for rendering this type?
There was a problem hiding this comment.
there probably is one. will start looking for it.
23Skidoo
reviewed
Jul 21, 2017
| Setup.Flag NoOptimisation -> "0" | ||
| Setup.Flag NormalOptimisation -> "1" | ||
| Setup.Flag MaximumOptimisation -> "2" | ||
| _ -> "1")] |
There was a problem hiding this comment.
I'd prefer an exhaustive pattern-match instead of a catch-all clause. That way we'll get a warning about an inexhaustive pattern match when the data type changes.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
This change will further compact the newly added Build Profile to new-build command in #4605 per @hvr's comment: #4605 (comment)
Before this change:
And after this change: