Add checkVersion for added fields
#4893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res, extra-library-flavours, and virtual-modules. As pointed out by @hvr, haskell#4857, haskell#4875 did not contain the necessary "check" logic. This PR tries to address this shortcoming.
|
That's what happens when we don't write tests for new features... Thanks to @hvr for spotting this. |
|
Merged, thanks! |
23Skidoo
reviewed
Nov 15, 2017
| , extraLibFlavours ])) $ | ||
| PackageDistInexcusable $ | ||
| "The use of 'asm-sources', 'cmm-sources', 'extra-bundled-libraries' " | ||
| ++ " and 'virtual-modules' requires the package " |
There was a problem hiding this comment.
Oops, looks like you need to s/virtual-modules/extra-library-flavours/ here. Feel free to commit directly to master.
There was a problem hiding this comment.
wow. How the hell did that happen? Ok... I'll just edit it on GH.
|
So this PR supposedly broke Travis. That has two implications: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @hvr, #4857, #4875 did not contain the necessary "check" logic. This PR tries to address this shortcoming.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!