Skip to content

Warn on multiply specified singular fields #5021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2018

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jan 12, 2018

Resolves #366


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@phadej phadej requested review from 23Skidoo and hvr January 12, 2018 12:06
There are no warnings (see .format file):
- when the file is both in included stanza and actual stanza
- when the field is overriden in if-conditional
@phadej phadej force-pushed the duplicate-singular-fields branch from 42c1459 to ce775db Compare January 14, 2018 10:08
@phadej phadej mentioned this pull request Jan 14, 2018
4 tasks
@phadej
Copy link
Collaborator Author

phadej commented Jan 14, 2018

@phadej phadej merged commit ce775db into haskell:master Jan 14, 2018
@phadej phadej deleted the duplicate-singular-fields branch January 14, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant