Skip to content

Prototype flag normalisation for GHC 8.0-8.4 #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 26, 2018

Conversation

merijn
Copy link
Collaborator

@merijn merijn commented Apr 17, 2018

Uses the just merged infrastructure to normalise commandline arguments to filter out any GHC flags that don't affect the build products. Currently only filters commandline arguments for GHC >=8.0 && <8.5 as those are the only versions I checked the flags for.

I went through the GHC DynFlags source for all those version to figure out which flags can be filtered and to follow the right format. Anything I wasn't sure about is left alone, some flags I'm still unsure about are documented in #4247.

Also filters out all haddock arguments, as those should never affect GHC build products.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@merijn merijn force-pushed the filter-flag-prototype branch from 9fe5edf to 338da71 Compare April 18, 2018 08:41
@merijn
Copy link
Collaborator Author

merijn commented Apr 25, 2018

Ok, I've been using this code for about a week now with no issues, none of the people in the original issue or that I've asked have objected, so unless someone has a complaint before tomorrow I'm merging this.

@merijn merijn merged commit 4bc9826 into haskell:master Apr 26, 2018
@merijn merijn deleted the filter-flag-prototype branch April 26, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant