Prototype flag normalisation for GHC 8.0-8.4 #5266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the just merged infrastructure to normalise commandline arguments to filter out any GHC flags that don't affect the build products. Currently only filters commandline arguments for GHC >=8.0 && <8.5 as those are the only versions I checked the flags for.
I went through the GHC DynFlags source for all those version to figure out which flags can be filtered and to follow the right format. Anything I wasn't sure about is left alone, some flags I'm still unsure about are documented in #4247.
Also filters out all haddock arguments, as those should never affect GHC build products.
Please include the following checklist in your PR:
[ci skip]
is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!