Extend packages in plan.json with pkg-src field #5487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvr
reviewed
Aug 1, 2018
| ] | ||
| RepoSecure{..} -> | ||
| J.object [ "type" J..= J.String "secure-repo" | ||
| , "path" J..= J.String repoLocalDir |
There was a problem hiding this comment.
do we really need the "path"? I don't feel like that's a relevant information; we already know the "remote" label; also the local repo cache path is to be considered an implementation detail; its on-disk format may easily change at some point to account for situations we can't currently represent properly yet.
And most importantly, nor is it even guaranteed that the package is currently cached there! It's called "cache" for a reason :-)
There was a problem hiding this comment.
yeah, let's remove that one.
hvr
approved these changes
Aug 1, 2018
This also enables and makes use of the Sphinx todo extension which provides an idiomatic way to annotate TODO items in .rst
hvr
added a commit
that referenced
this pull request
Aug 2, 2018
hvr
added a commit
that referenced
this pull request
Aug 2, 2018
(cherry picked from commit 511d03d) Co-authored-by: Alex Biehl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends packages in the
plan.jsonfile with apkg-srcfield. This is really helpful for third-party tooling to find the paths to all the project local packages including source repositories and such./cc @hvr @shlevy