Skip to content

Reduce CI matrix for PRs #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dwijnand
Copy link
Contributor

Fixes #4384

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

The ticket (#4384) mentions:

we should have some mechanism for triggering the extra tests in PR if a user wants them (e.g., a high risk commit.)

I'm thinking that for high risk commits perhaps calling the API to trigger an "api"-type build (as opposed to a "pull_request"-type build) would run the additional jobs. WDYT?

@phadej
Copy link
Collaborator

phadej commented Nov 1, 2019

No way. It takes time, but CI catches problems especially with older GHCs.

I.e. this is not a proper solution.

@phadej phadej closed this Nov 1, 2019
@phadej
Copy link
Collaborator

phadej commented Nov 1, 2019

EDIT: to expand. The master have been red for extensive amount of time, and no one had time to fix it. I won't make it any easier to accidentally turn red again.

Test locally, don't spam Travis.

@dwijnand
Copy link
Contributor Author

dwijnand commented Nov 1, 2019

Make sense. Then I take it #4384 should closed. I'll see if I'm able to help by fixing master.

@dwijnand dwijnand deleted the reduce-ci-matrix-for-prs branch November 1, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Adjust ci jobs to actual pr changes
2 participants