Skip to content

Bootstrap rewrite by bgamari #6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jul 20, 2020

Continuation to #6700. cc @bgamari.

@phadej phadej changed the title Bootstrap bgamari Bootstrap rewrite by bgamari Jul 20, 2020
@phadej phadej requested a review from bgamari July 20, 2020 21:06
@phadej phadej force-pushed the bootstrap-bgamari branch 2 times, most recently from bafc7b5 to 5a31ae2 Compare July 20, 2020 21:13
Copy link
Contributor

@bgamari bgamari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Moving the plan generation out of the script is a nice improvement.

bgamari and others added 5 commits July 23, 2020 00:20
The plan: A JSON file (generated with bootstrap.py --extract-plan)
containing dependency and source information is built from plan.json.
This is then used to fetch and build the bootstrapping dependencies.
Since this is only to be used for bootstrapping on new architectures, we
advise the users to only use the resulting cabal-install executable to
build a proper cabal-install.
@phadej phadej force-pushed the bootstrap-bgamari branch from 5a31ae2 to 859f1f2 Compare July 22, 2020 21:21
@phadej phadej mentioned this pull request Jul 22, 2020
@phadej phadej added this to the 3.4.0.0 milestone Jul 22, 2020
@phadej phadej merged commit 269d2db into haskell:master Jul 23, 2020
@phadej phadej deleted the bootstrap-bgamari branch July 23, 2020 08:08
@phadej phadej mentioned this pull request Jul 23, 2020
@phadej
Copy link
Collaborator Author

phadej commented Sep 2, 2020

Backported in #6987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants