Skip to content

Fix win release ext #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 6, 2022
Merged

Fix win release ext #8191

merged 6 commits into from
Jun 6, 2022

Conversation

jneira
Copy link
Member

@jneira jneira commented Jun 1, 2022 •
edited
Loading

@jneira jneira requested review from Mikolaj and hasufell June 1, 2022 22:17
@jneira jneira marked this pull request as draft June 1, 2022 22:53
@jneira
Copy link
Member Author

jneira commented Jun 1, 2022

@jneira jneira marked this pull request as ready for review June 1, 2022 23:15
Mikolaj
Mikolaj approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm in the test pipeline windows has .exe and at least one of the linux archives has no .exe.

Thank you so much @jneira.

@Mikolaj Mikolaj mentioned this pull request Jun 3, 2022
Closed
robx
robx approved these changes Jun 5, 2022
View reviewed changes
Copy link
Collaborator

@robx robx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jneira
jneira commented Jun 5, 2022
View reviewed changes
.gitlab/ci.sh
@@ -61,18 +63,18 @@ args=(
run cabal v2-build ${args[@]} cabal-install

mkdir "$CI_PROJECT_DIR/out"
cp "$(cabal list-bin ${args[@]} cabal-install:exe:cabal)" "$CI_PROJECT_DIR/out/cabal"
cp "$(cabal list-bin ${args[@]} cabal-install:exe:cabal)" "$CI_PROJECT_DIR/out/cabal$EXE_EXT"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here there is no curly braces so i will not add them neither

@jneira jneira added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Jun 5, 2022
@mergify mergify bot merged commit 49a4946 into haskell:master Jun 6, 2022
@Mikolaj
Copy link
Member

Mikolaj commented Jun 6, 2022

@Mergifyio backport 3.8

@mergify mergify bot mentioned this pull request Jun 6, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2022

backport 3.8

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jun 6, 2022
@jneira @robx @mergify
Fix win release ext (#8191)
2a2a909 
* Fix cabal exec extension for win

* Use tabs in the changed region

* Use exe ext when zipping

* Apply suggestions from code review

Co-authored-by: Robert <[email protected]>

* Add curly braces to var

Co-authored-by: Robert <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 49a4946)
Mikolaj added a commit that referenced this pull request Jun 6, 2022
@Mikolaj
Merge pull request #8197 from haskell/mergify/bp/3.8/pr-8191
71fc82c 
Fix win release ext (backport #8191)
@ulysses4ever ulysses4ever mentioned this pull request Jun 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robx robx robx approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

@hasufell hasufell Awaiting requested review from hasufell

Assignees
No one assigned
Labels
squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cabal 3.4.0.0 release on Windows lacks extensions
3 participants
@jneira @Mikolaj @robx