-
Notifications
You must be signed in to change notification settings - Fork 711
cabal init -i: add the GHC2021 language option #8277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c967d2
to
57bcc77
Compare
good work, I would say this is in the limit of needing tests, maybe an unit test? |
@jneira there's a test that the new language is on the list: What else can be tested here? |
hmm, maybe not an unit test but a test checking the produced cabal file has the correct language set, but I hope it is already tested with other values somewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks again!
@jneira thanks! I went ahead and added a test that actually checks the contents of the cabal file. |
@mergify backport 3.8 |
✅ Backports have been created
|
cabal init -i: add the GHC2021 language option (backport #8277)
fix #8265
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!