Skip to content

cabal init -i: add the GHC2021 language option #8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2022
Merged

cabal init -i: add the GHC2021 language option #8277

merged 1 commit into from
Jul 9, 2022

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Jul 9, 2022

fix #8265

Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@jneira
Copy link
Member

jneira commented Jul 9, 2022

good work, I would say this is in the limit of needing tests, maybe an unit test?

@ulysses4ever
Copy link
Collaborator Author

@jneira there's a test that the new language is on the list:
https://github.com/haskell/cabal/pull/8277/files#diff-087fb21b3293d2ef32df883500fad0ead4fa4281b0ba0d376ea36928164567afR915

What else can be tested here?

@jneira
Copy link
Member

jneira commented Jul 9, 2022

hmm, maybe not an unit test but a test checking the produced cabal file has the correct language set, but I hope it is already tested with other values somewhere

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks again!

@ulysses4ever
Copy link
Collaborator Author

@jneira thanks! I went ahead and added a test that actually checks the contents of the cabal file.

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jul 9, 2022
@mergify mergify bot merged commit e190c18 into master Jul 9, 2022
@ulysses4ever
Copy link
Collaborator Author

@mergify backport 3.8

@mergify
Copy link
Contributor

mergify bot commented Jul 9, 2022

backport 3.8

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jul 10, 2022
cabal init -i: add the GHC2021 language option (backport #8277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal init: suggest GHC2021?
4 participants