Don't warn about 'prepositive-qualified-module' in Paths_pkgs

[martijnbastiaan]

Enabling '-Wprepositive-qualified-module' in a project leads to warnings
when used in combination with Cabal's Paths_* feature. Given that this
is code outside of a user's control, this warning should be disabled
locally.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[martijnbastiaan]

T3827 sporadically fails, but I don't think it has anything to do with this PR :)

[Mikolaj]

LGTM.

BTW, that's an interesting failure. Let me rerun CI and see if it repeats.

[martijnbastiaan]

BTW, that's an interesting failure. Let me rerun CI and see if it repeats.

Yeah, I got it while testing on my own repo too.

It seems to happen ~50% of the time. Let me just scrap that comment, CI tests a mix of operation systems, and I can't seem to reproduce it locally anymore.

[Mikolaj]

Yeah, I got it while testing on my own repo too. It seems to happen ~50% of the time.

On Linux? Which GHC version?

[martijnbastiaan]

It failed on macos-latest ghc-9.2.3 (and locally on Ubuntu, but I can't seem to reproduce that now).

[martijnbastiaan]

I've only seen it on GHC 9.2.

[martijnbastiaan]

Last CI failure on github.com/martijnbastiaan: https://github.com/martijnbastiaan/cabal/runs/7646056444?check_suite_focus=true.

[Mikolaj]

I think I've fixed CI, do let me rebase and check.

[Mikolaj]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[ulysses4ever]

LGTM, thanks @martijnbastiaan! do you want to apply the merge-me label?

[martijnbastiaan]

Yes please.

[Mikolaj]

@martijnbastiaan: I took the liberty of giving you the Triage privilege for the cabal repo. If this is OK, please verify by setting the merge_me label.

[martijnbastiaan]

Done! Let's see if it gets picked up.

[ulysses4ever]

@martijnbastiaan just in case: we have a Mergify setting that makes it wait for 2 days before merging (this is to ensure that everyone is happy have chance to chime in if not).

[Mikolaj]

Let me rebase to see if the recent CI workaround unblocks merging.

[Mikolaj]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[Mikolaj]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[andreasabel]

Thanks for the PR!
I have some stylistic nit-picking...

[martijnbastiaan]

I've applied the style suggestions. Given that this was approved before and that it hasn't attracted further comments, I've taken the liberty to re-apply the merge me label.

[Mikolaj]

@martijnbastiaan: thank you for the PR once again.