-
Notifications
You must be signed in to change notification settings - Fork 711
Add 3.10.1.0 changelogs and remove the used up tiny changlog files #8831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
484c840
to
e3bbe7a
Compare
I'm not a big fan of repeating important changes to Cabal in cabal-install changelog: they're already out of sync (besides, I'm not sure it's all that helpful). |
Sure. But I suggest we should rather educate PR authors (and improve our CONTRIBUTING material) than patch the changelogs. Please open a ticket about it if you have a short outline of the policy change we could enact. |
fcc6600
to
f8f2692
Compare
Mm, perhaps I didn't get what this means:
I meant the "pasted" bit. Can we not paste anything that has already been said somewhere? It's a way to disaster usually. But if it's a consequence of people putting "component: Cabal, cabal-install" in the changelogs, than I don't suggest we add even more work for the release and remove them manually. |
Oh, yes, I meant 'pasted by the changelog-d utility due to users saying "component: Cabal, cabal-install"'. I haven't pasted anything manually. I'm lazy. I also haven't removed manually (almost) anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github marks some of my comments as Pending, so let me see if finishing a review fixes that
Edit: it did.
Edit2: though the comments are misplaced. Let me copy them where they belong.
Edit3: oh no, they are already copied there.
@Mikolaj how about pulling up |
7a0247d
to
45c31c6
Compare
Right. Done. |
@mergify backport 3.10 |
❌ No backport have been created
Git reported the following error:
|
45c31c6
to
e3b782b
Compare
let me speed up the merging of cabal 3.10 changelogs so that we have candidates ready for tomorrows dev's meeting |
@mergify backport 3.10 |
❌ No backport have been created
Git reported the following error:
|
@mergify rebase |
@mergify backport 3.10 |
☑️ Nothing to do
|
❌ No backport have been created
Git reported the following error:
|
@Mikolaj : Sorry, I am travelling atm, so I missed the meeting and the latest action here. Hope you got the necessary feedback yesterday. |
Yes, @andreasabel, we are fine. :) Have a great trip! |
The remaining chagelog files are indeed those we haven't managed to fit it. I haven't checked if the removed files match what's in the changelog documents themselves nor did I check all the PRs mentioned in the
changelog-d
utility warnings (https://paste.tomsmeding.com/N5YLPa58; many or most of which seem to be false positives).I've created the files strictly following https://github.com/haskell/cabal/wiki/Making-a-release