Combine non-installable and non-upgradable package lists (fixes #8581) #9148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Jul 26, 2023
|
LGTM, as far as I can tell we are consolidating dealing with non-reinstallable packages into cabal-install, removing some machinery from cabal-install-solver. Very happy with this. I noted a couple of minor cleanups we could do, I'd appreciate if you could have a look. |
grayjay
commented
Jul 26, 2023
…ll#8581) This commit continues the work in b016e59 to combine the lists of non-installable and non-upgradable packages. When a package is in the list, it means that the solver will only consider installed instances of that package. This commit renames the list from "non-upgradable" to "non-reinstallable" to clarify that the packages cannot be upgraded or downgraded. There should be no change in behavior, except for the wording of solver error messages.
The TODO deleted in 4d3f7b5 suggests that the special case was only needed for the top-down solver, which has been removed.
|
Thanks! I rebased onto master. |
mergify
bot
added
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit continues the work in b016e59 to combine the lists of non-installable and non-upgradable packages. When a package is in the list, it means that the solver will only consider installed instances of that package. This commit renames the list from "non-upgradable" to "non-reinstallable" to clarify that the packages cannot be upgraded or downgraded. There should be no change in behavior, except for the wording of solver error messages.
Please read Github PR Conventions and then fill in one of these two templates.
Template Β: This PR does not modify
cabalbehaviour (documentation, tests, refactoring, etc.)Include the following checklist in your PR: