Skip to content

Conversation

@philderbeast
Copy link
Collaborator

This is a doc change only, adding a note on how to do "not equal" with constraints when we do not have that operator.

@philderbeast philderbeast marked this pull request as draft October 30, 2023 13:53
@philderbeast philderbeast force-pushed the doc/exclude-version-constraint branch 6 times, most recently from f3c2e2d to 255d228 Compare October 30, 2023 15:02
@ulysses4ever
Copy link
Collaborator

Overall makes sense, thank you!

@philderbeast philderbeast force-pushed the doc/exclude-version-constraint branch from 1a0f580 to 5b48e28 Compare November 5, 2023 14:06
@philderbeast
Copy link
Collaborator Author

philderbeast commented Nov 5, 2023

This change to include "not equal" also would help with the "negation operator" question of #5373 wouldn't it?

This note uses the or trick from @23Skidoo in #5373 (comment).

@philderbeast philderbeast marked this pull request as ready for review November 5, 2023 14:32
@philderbeast philderbeast requested a review from 23Skidoo November 5, 2023 14:34
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

No reason to request reviews from 23skidoo: he is not involved into it these days.

@philderbeast
Copy link
Collaborator Author

I found an open feature request for a /= operator in #4919.

@philderbeast philderbeast force-pushed the doc/exclude-version-constraint branch from 5b48e28 to 9a0505f Compare November 7, 2023 14:16
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Nov 9, 2023
@mergify mergify bot merged commit 398a9bf into haskell:master Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge+no rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants