Stop logging to file when build inplace #9607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ulysses4ever @Mikolaj, as the previous reviewers, could you swiftly review this fix that undoes my mistake? |
geekosaur
approved these changes
Jan 10, 2024
alt-romes
force-pushed
the
wip/romes/9606
branch
from
83d10da to
d497782
Compare
ulysses4ever
approved these changes
Jan 10, 2024
|
Thank you both. As I was debugging a tree on master I was very confused by not seeing the output of |
|
@Mikolaj @Kleidukos I suggest we skip the merge delay. I fear developer workflows may break because of my mistake in the meantime. |
|
Happens to all of us. You don't make mistakes only if you don't do anything at all! |
Mikolaj
approved these changes
Jan 11, 2024
Mikolaj
added
the
merge delay passed
|
@mergify rebase |
✅ Nothing to do for rebase action |
|
Let me keep restarting CI until we hit the not-yet-affected macos containers. |
|
Nope, this does not converge, the failing CI job, on with randomly bad container, cancels all others too early. Let's fix CI first, as discussed in the Matrix channel. |
|
@mergify rebase |
Mikolaj
force-pushed
the
wip/romes/9606
branch
from
d497782 to
f839985
Compare
✅ Branch has been successfully rebased |
In f70fc98, while refactoring buildInplaceUnpackedPackage and buildAndInstallUnpackedPackage, we started logging into a file on both cases, instead of logging to a file only for buildAndInstallUnpackedPackage. When building a package inplace, it is much more useful to be able to see the GHC invocation directly outside of a log file. This is especially relevant for Cabal developers working inplace. Fixes haskell#9606
Mikolaj
force-pushed
the
wip/romes/9606
branch
from
f839985 to
83aaa63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f70fc98, while refactoring buildInplaceUnpackedPackage and buildAndInstallUnpackedPackage, we started logging into a file on both cases, instead of logging to a file only for buildAndInstallUnpackedPackage.
When building a package inplace, it is much more useful to be able to see the GHC invocation directly outside of a log file.
This is especially relevant for Cabal developers working inplace.
Fixes #9606