-
Notifications
You must be signed in to change notification settings - Fork 711
Add static pre-release job #9649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@TeofilC Thanks for this! |
d8173dc
to
9570602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool. Have you tried it on your fork by any chance? Should suffice to merge it into master there.
Good point. I've done that now with this commit, so we can see what a merged pipeline looks like: TeofilC@831a98f |
9570602
to
360e539
Compare
Looks like it works? I tried the binary (from here) on my NixOS and it looks fine. Since you dived into the pre-release business a bit, could you also add some documentation (one paragraph could be enough but as you see fits...). How to get them is already mentioned in README, so that's covered. But I think a subsection in CONTRIBUTING.md about how they're implemented would be nice. This was mentioned on Matrix last week... Also, README has to be updated to mention the static binary. Is it the case that we only want Linux? I personally think it's fine, but we should say something somewhere in the docs... |
Sweet! I'm glad its working. I'll write up some documentation later today. I'll take this opportunity to document the workaround from #9632 somewhere. For the bit in CONTRIBUTING.md, I'm thinking something that gives a high level overview for how pre-releases get generated (which jobs, etc), and mention how the static one works in particular. Is that what you had in mind? |
I've added a commit with some extra documentation. Let me know if that's what you had in mind @ulysses4ever or if you'd like something more/else.
I would add non-Linux ones but I don't know how static linking works on non-linux. I've listed the configurations we have for preview releases in CONTRIBUTING.md now. |
7ec92da
to
873f257
Compare
(the last force-push was just a rebase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little wordsmithing from me, but in general it's great!
b63e75e
to
cdcec19
Compare
cdcec19
to
9460f17
Compare
I just realised I actually forgot to mention the workaround from #9632 so I've actually added that now to the README.md file 😅 |
e0fa858
to
c40031d
Compare
Add a job that builds a statically linked cabal-install executable, and make it available for pre-releases. Resolves #9631.
Co-authored-by: Artem Pelenitsyn <[email protected]>
c40031d
to
fa333bb
Compare
Add a job that builds a statically linked cabal-install executable, and make it available for pre-releases.
Resolves #9631.
Feedback is appreciated!
In particular, I'm not sure how we want to specify the GHC version we want for this job. I've used a singleton matrix but maybe something else is better.
I've chosen to use a standard alpine image and the haskell setup action rather than a pre-baked alpine image with GHC, since we need to install the latest version of cabal-install for the test suite anyway, and this keeps things similar to the other jobs.