Improve Ord IntSet instance

[treeowl]

An attempt was made in #670, but it proved to have some subtle bug in #783 and had to be reverted. It would be nice to fix and reinstate.

[jwaldmann]

I'm on it. First step is to trigger the bug in testing. I made an Arbitrary instance that produces larger numbers jwaldmann@80af818 (this may be generally useful?) and then indeed I am seeing the mis-behaviour with

stack  test :intset-properties --ta '-t instance'  --ta '-a 100000'

I will next look into a proposed fix jwaldmann@259b737 but it's not working as-is.

[jwaldmann]

This Large generator already exists (https://hackage.haskell.org/package/QuickCheck-2.14.2/docs/Test-QuickCheck.html#t:Large) so I am using that 7d89135 . All intset-properties look good - except for the Ord-related ones. An example is

prop_instanceOrdIntSet: [Failed]
*** Failed! Falsified (after 6487 tests):
fromList [8614693178962916916,9139268739591489368]
fromList [2968846309351689790,4115242320062133052,8853465997820928815]
(used seed 4781226516308396838)

this is probably related to some overflow that changes the sign.

Yes - 182b06b looks good now.

[jwaldmann]

How should I proceed here? I think the issue is fixed. Rebase the fix on #788?

[treeowl]

Weren't you trying to fix the clever instance?

[jwaldmann]

I think I did (

containers/containers/src/Data/IntSet/Internal.hs

Line 1217 in 182b06b

instance Ord IntSet where

) I'm just asking how you want the PR.

[treeowl]

I feel like there's some communication issue going on here, but I'm confused as to who doesn't understand whom and why. Yes, I'd expect you to rebase your improvement branch on master and submit a PR, but if you have other intentions just explain again please.

[jwaldmann]

Sorry for being not clear. I was waiting for #788 to land. It is orthogonal in the source - the connection is that it would have caught the bug in this "clever" instance. Anyway I will base on (current) master.

[meooow25]

@jwaldmann any chance you would want to try this again, since #788 is resolved?

[jwaldmann]

yes I will look into this.

[meooow25]

@jwaldmann just checking if you made some progress on this. Would be nice to wrap this up. I could give it a try if you've been too busy.

[jwaldmann]

Sorry for the ongoing delay, and thanks for the offer. I am trying this week. After that - you may take over.

[meooow25]

@jwaldmann, any luck?

[meooow25]

I'll try implementing this tomorrow.