Skip to content

assume a default content type of text/html when negotiating content #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gbaz
Copy link
Contributor

@gbaz gbaz commented Feb 23, 2022

should help with the test failure on #996

I can't see any potential downside here. Modern http clients will almost certainly send an accepts header. The current behavior is nonuniform because the "default" varies by whatever content type is listed first. And I think it is most in keeping with the spirit of the old web to assume people want html unless they specify otherwise.

That said I'll let it sit for a few days before merging and see if there is comment.

@gbaz
Copy link
Contributor Author

gbaz commented Feb 24, 2022

This change is already included in the above mentioned pr so closing.

@gbaz gbaz closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant