Skip to content

Add lastVersion in listings (#749) #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2022
Merged

Add lastVersion in listings (#749) #1140

merged 2 commits into from
Dec 31, 2022

Conversation

blackheaven
Copy link
Contributor

No description provided.

@blackheaven
Copy link
Contributor Author

is there anything I can do/improve to get it merged?

@andreasabel
Copy link
Member

is there anything I can do/improve to get it merged?

If you ask like this, the answer is yes.
Replace your empty description by:

  • motivation of the change
  • description of the change
  • screenshot to illustrate UI change (if any)
  • migration guide for API change (if any)

@gbaz
Copy link
Contributor

gbaz commented Dec 27, 2022

While that's good general advice, in this case I think its pretty clear with this PR (though a nice description is always helpful!). I'm going to try to get to a bunch of outstanding hackage PRs this holiday season.

@andreasabel
Copy link
Member

@gbaz wrote:

I'm going to try to get to a bunch of outstanding hackage PRs this holiday season.

Excellent!

@gbaz
Copy link
Contributor

gbaz commented Dec 30, 2022

tested locally and doesn't appear to work

image

@gbaz gbaz added the blocked label Dec 30, 2022
@blackheaven
Copy link
Contributor Author

Sorry, I've pushed the fix

image

@gbaz
Copy link
Contributor

gbaz commented Dec 31, 2022

works, thanks!

@gbaz gbaz merged commit f624f6f into haskell:master Dec 31, 2022
@blackheaven blackheaven mentioned this pull request Jan 1, 2023
Closed
gbaz added a commit that referenced this pull request Jan 5, 2023
@gbaz @peterbecich
@andreasabel @Kleidukos @mpickering @Bodigrim @AliasQli @kubaneko @blackheaven @ysangkok @LeviButcher
master -> central server jan 2023 (#1158)
6a1232e 
* delete unused GitHub Action; fix CI badge

* Fix #1076: separate validators from UI and doctest them (#1077)

* Cachix caching for nix-shell GitHub Action (#1081)

* Add uploaded_at field in package api (#1080)

* package page: Include virtual-modules in module tree (#1085)

* Allow hashable-1.4 and text-2.0 (#1089)

* Divide sitemap into parts

* Add sitemap link for subdirectories

* Fix `non-canonical-return` warnings

* Bump CI to GHC 9.2.3 and restrict to master branch

* Check authorisation (#1111)

* Dynamically add css piece

* Fix #1105: change order of markdown parsers to allow pipes in lists

* Fix #1128, fix #1130 by adding bounds to Cabal-syntax and haddock-library

* Bump CI to 9.2.4 and some deps

* Force .txt and .text to have UTF-8 MIME charset (#1133)

* Upgrade to haddock-library-1.11.0 (#1126)

* attempt to speed up GitHub Action for Nix Shell

* work with cabal 3.8

* Updated accepted licenses (#1092)

* Add dependabot for github workflows

* Bump cachix/cachix-action from 10 to 12

* Bump actions/checkout from 2.4.0 to 3.1.0
* Bump cachix/install-nix-action from 17 to 18

* Build with Cabal-3.8 and GHC 9.4 (#1141)

* Haskell CI: bump to Ubuntu-22.04, GHC 9.2.5 and 9.4.4

* Allow mtl-2.3 and transformers-0.6 (#1150)

* Disable test (#1124)

* allow disable tests on client side

* add deprecated version warning (#1123)

* List maintainers on package page (#1098)

* List maintainers on package page

* Vendor snowball package (#1116)

* Add searchbox metadata (#1115)

* Add captcha for user registration (#1099)

* remove filtering 00-index for cabal version < 2.0 hack (#1152)

* Add lastVersion in listings (#749) (#1140)

* rm icu dep instructions, add libgd

* Add test log display (#1100)

* Add test log

* Reverse Dependencies indexed on PackageName (#1082)

* Rebased Reverse Dependencies

* Add "Quick Jump" to candidate package page (#1122)

* Solves #1029 - Adds paging to recent packages and recent revisions (#1055)

* support for `prefers-color-scheme` (#1008)

* 2x brightness for captions and links in dark color scheme

* table dark color scheme

* prefers-color-scheme for links, footer, and table-of-contents

* paginator css for `prefers-color-scheme`

* Maintainer notifications

* cleanup partial functions for revdeps, elim use of MonadThrow, MonadCatch

* fix tests enablement link

Co-authored-by: Peter Becich <[email protected]>
Co-authored-by: Andreas Abel <[email protected]>
Co-authored-by: Hécate Moonlight <[email protected]>
Co-authored-by: Matthew Pickering <[email protected]>
Co-authored-by: ˌbodʲɪˈɡrʲim <[email protected]>
Co-authored-by: Alias Qli <[email protected]>
Co-authored-by: Ondřej Kubánek <[email protected]>
Co-authored-by: Gautier DI FOLCO <[email protected]>
Co-authored-by: Janus Troelsen <[email protected]>
Co-authored-by: Levi Butcher <[email protected]>
@gbaz gbaz mentioned this pull request Jan 6, 2023
Merged
@ysangkok
Copy link
Member

ysangkok commented Jan 31, 2023 •
edited
Loading

@blackheaven
seems like lastVersion is not updated on package addition: packageChangeHook

if you upload a new package version , the new version isn't shown in the browse listing. This can be reproduced using the instructions in #1168.

Seem like itemLastVersion should be updated in addition to itemLastUpload, would you agree?

@blackheaven
Copy link
Contributor Author

Hello,

It seems so, do you want to push the fix yourself, or can I handle it?

@ysangkok
Copy link
Member

@blackheaven you feel free to handle it!

@blackheaven blackheaven mentioned this pull request Feb 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blackheaven @andreasabel @gbaz @ysangkok