Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Don't show 'QuickJump' button in header if not present #783

Closed
alexbiehl opened this issue Mar 21, 2018 · 0 comments
Closed

Don't show 'QuickJump' button in header if not present #783

alexbiehl opened this issue Mar 21, 2018 · 0 comments
Labels
good first issue

Comments

@alexbiehl
Copy link
Member

We always show the QJ button even if the package wasn't generated with --quickjump flag. This is confusing!

bildschirmfoto 2018-03-21 um 11 06 25
@alexbiehl alexbiehl mentioned this issue Mar 23, 2018
Closed
@alexbiehl alexbiehl mentioned this issue Mar 30, 2018
Merged
mpilgrem added a commit to mpilgrem/haddock that referenced this issue Nov 10, 2019
@mpilgrem
Fix haskell#783 Don't show button if --quickjump not present
ea0a550 
In the TypeScript `init.ts`, makes `quickJump.init()` (which creates the button) conditional on the presence of meta tag `hasQuickJump` with content `"true"`.

In the Haskell, threads the `withQuickJump` flag result through to `headHtml` to create the meta tag, accordingly.
mpilgrem added a commit to mpilgrem/haddock that referenced this issue Nov 13, 2019
@mpilgrem
Fix haskell#783 Don't show button if --quickjump not present
ffa435e
mpilgrem added a commit to mpilgrem/haddock that referenced this issue Nov 13, 2019
@mpilgrem
Fix haskell#783 Don't show button if --quickjump not present
1f83c35
mpilgrem added a commit to mpilgrem/haddock that referenced this issue Mar 24, 2020
@mpilgrem
Fix haskell#783 Don't show button if --quickjump not present
467551d
mpilgrem added a commit to mpilgrem/haddock that referenced this issue Jan 15, 2021
@mpilgrem
Fix haskell#783 Don't show button if --quickjump not present
75fe4eb
emilypi pushed a commit to mpilgrem/haddock that referenced this issue Jun 6, 2022
@mpilgrem @mergify
Fix haskell#783 Don't show button if --quickjump not present
fafedd9
mpilgrem added a commit to mpilgrem/haddock that referenced this issue Jun 12, 2022
@mpilgrem
Fix haskell#783 Don't show button if --quickjump not present
b4c1550
@mergify mergify bot closed this as completed in 3ab18cf Jun 13, 2022
mergify bot added a commit that referenced this issue Jun 13, 2022
@mergify
Merge pull request #1108 from mpilgrem/fix783
118dd4e 
Fix #783 Don't show button if --quickjump not present
mpickering added a commit that referenced this issue Aug 16, 2022
@mpickering
Revert "Fix #783 Don't show button if --quickjump not present"
c59a3bb 
This reverts commit 3ab18cf.

This commit breaks the quickjump functionality on `hackage.haskell.org`.

See https://gitlab.haskell.org/ghc/ghc/-/issues/21984
bgamari pushed a commit that referenced this issue Aug 20, 2022
@mpickering
Revert "Fix #783 Don't show button if --quickjump not present"
421e4c3 
This reverts commit 3ab18cf.

This commit breaks the quickjump functionality on `hackage.haskell.org`.

See https://gitlab.haskell.org/ghc/ghc/-/issues/21984
bgamari pushed a commit that referenced this issue Aug 7, 2023
@mpickering
Revert "Fix #783 Don't show button if --quickjump not present"
9b4748b 
This reverts commit 3ab18cf.

This commit breaks the quickjump functionality on `hackage.haskell.org`.

See https://gitlab.haskell.org/ghc/ghc/-/issues/21984
bgamari pushed a commit that referenced this issue Oct 7, 2023
@mpickering @bgamari
Revert "Fix #783 Don't show button if --quickjump not present"
ad31d96 
This reverts commit 3ab18cf.

This commit breaks the quickjump functionality on `hackage.haskell.org`.

See https://gitlab.haskell.org/ghc/ghc/-/issues/21984
hubot pushed a commit to ghc/ghc that referenced this issue May 17, 2024
@mpilgrem
Fix haskell/haddock#783 Don't show button if --quickjump not present
7776566
hubot pushed a commit to ghc/ghc that referenced this issue May 17, 2024
@mergify
Merge pull request haskell/haddock#1108 from mpilgrem/fix783
b0e079b 
Fix haskell/haddock#783 Don't show button if --quickjump not present
hubot pushed a commit to ghc/ghc that referenced this issue May 24, 2024
@wz1000
Revert "Fix haskell/haddock#783 Don't show button if --quickjump not …
be9c311 
…present"

This reverts commit 7776566.
hubot pushed a commit to ghc/ghc that referenced this issue May 24, 2024
@wz1000
Revert "Fix haskell/haddock#783 Don't show button if --quickjump not …
c58a127 
…present"

This reverts commit 7776566.
hubot pushed a commit to ghc/ghc that referenced this issue May 24, 2024
@wz1000
Revert "Fix haskell/haddock#783 Don't show button if --quickjump not …
14e554c 
…present"

This reverts commit 7776566.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexbiehl