Skip to content

Set module name to <name> is suggested even if the module is already called <name> #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
konsumlamm opened this issue Mar 23, 2022 · 4 comments · Fixed by #2826
Closed

Set module name to <name> is suggested even if the module is already called <name> #2797

konsumlamm opened this issue Mar 23, 2022 · 4 comments · Fixed by #2826
Labels
component: hls-module-name-plugin GHC issues with particular GHC versions type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@konsumlamm
Copy link

konsumlamm commented Mar 23, 2022 •
edited
Loading

Example

set_module_name

Version

GHC version: 9.2.1
HLS version: 1.6.1.0
@fendor
Copy link
Collaborator

fendor commented Mar 24, 2022

Thank you for your bug report!
Moving to HLS repo which provides this feature

@fendor fendor transferred this issue from haskell/vscode-haskell Mar 24, 2022
@fendor fendor added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. pr welcome component: hls-module-name-plugin and removed status: needs triage labels Mar 24, 2022
@July541
Copy link
Collaborator

July541 commented Mar 27, 2022 •
edited
Loading

It seems hard to reproduce, even I'm sure I've met this

@konsumlamm
Copy link
Author

To be clear: this happens for any module I load.

It seems to only occur when using GHC 9.2.1 though, with GHC 9.0.2 and 8.10.7 everything is fine.

@Jashweii
Copy link

I also get this, on both 9.2.1 and 9.2.2 (haven't tried another version). I get it on both wsl ubuntu (hls master) and windows (1.6.1.0) on vscode.

@Ailrun Ailrun added the GHC issues with particular GHC versions label Apr 12, 2022
@July541 July541 mentioned this issue Apr 12, 2022
Merged
@mergify mergify bot closed this as completed in #2826 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: hls-module-name-plugin GHC issues with particular GHC versions type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Should no related code lens if the module name is correct July541/haskell-language-server
5 participants
@fendor @Ailrun @July541 @Jashweii @konsumlamm