Should no related code lens if the module name is correct - #2826
Merged
Conversation
July541
changed the title
July541
commented
Apr 12, 2022
| let path = "diagnostics" </> "Foo.hs" | ||
| _ <- openDoc path "haskell" | ||
| expectProgressMessages [pack ("Setting up testdata (for " ++ path ++ ")"), "Processing", "Indexing"] [] | ||
| , knownBrokenForGhcVersions [GHC92] "No evaluation status with GHC 9.2" $ requiresEvalPlugin $ testCase "eval plugin sends progress reports" $ |
Collaborator
Author
There was a problem hiding this comment.
Not know how did it pass the previous tests.
michaelpj
approved these changes
Apr 13, 2022
michaelpj
left a comment
michaelpj
left a comment
Collaborator
There was a problem hiding this comment.
Nice! Good bug hunting.
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
May 21, 2022
* Should no code lens if the module name is correct * Rerun tests * Rerun tests * Try remove hls-eval-plugin known-broken in ghc-9.2 * Rerun tests * Apply more accurate test name Co-authored-by: Michael Peyton Jones <me@michaelpj.com> Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2797.