Skip to content

Test "add missing module (non workspace)" is very flaky #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wz1000 opened this issue Apr 16, 2022 · 1 comment · Fixed by #2835
Closed

Test "add missing module (non workspace)" is very flaky #2831

wz1000 opened this issue Apr 16, 2022 · 1 comment · Fixed by #2835
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@wz1000
Copy link
Collaborator

wz1000 commented Apr 16, 2022

It consistently fails on CI for #2789 but I can't reproduce it locally. I'm disabling it for now.
@wz1000 wz1000 added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. status: needs triage labels Apr 16, 2022
@pepeiborra
Copy link
Collaborator

pepeiborra commented Apr 17, 2022 •
edited
Loading

It reproduces locally for me with #2831 - rather than flaky, it never passes.
With #2831^1 (2da5931) the test passes locally.
So it looks like #2831 has broken it.

EDIT: I was just lucky, it does pass sometimes with #2831 so it's just become flaky.

@pepeiborra pepeiborra mentioned this issue Apr 18, 2022
Merged
@mergify mergify bot closed this as completed in #2835 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky test haskell/haskell-language-server
2 participants
@pepeiborra @wz1000