Skip to content

Position mapping is occasionally broken #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pepeiborra opened this issue Aug 14, 2020 · 4 comments
Closed

Position mapping is occasionally broken #744

pepeiborra opened this issue Aug 14, 2020 · 4 comments
Labels
component: ghcide component: lsp type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@pepeiborra
Copy link
Collaborator

Noticeable when your code doesn't type check, after a few edits. Screenshots attached
This is a regression from 0.2.0.

Last good code:
image

Edited code:
image

Bad hover:
image
@pepeiborra pepeiborra changed the title Position mapping is broken in HEAD Position mapping is broken with GHC 8.4 Aug 15, 2020
@pepeiborra
Copy link
Collaborator Author

pepeiborra commented Sep 6, 2020 •
edited
Loading

It does happen with 8.8.4, the bug is definitely there.

EDIT: I was actually using HLS 0.3.0 on 8.8.4, not ghcide, when it reproduced.

@pepeiborra pepeiborra changed the title Position mapping is broken with GHC 8.4 Position mapping is occasionally broken Dec 30, 2020
@pepeiborra pepeiborra transferred this issue from haskell/ghcide Dec 30, 2020
@jneira jneira added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: ghcide labels Dec 31, 2020
@jneira
Copy link
Member

jneira commented Jan 31, 2022

I wonder if it is reproduced with lastest versions of hls and lsp

@michaelpj
Copy link
Collaborator

No recent reproductions, tentatively closing

@soulomoon
Copy link
Collaborator

soulomoon commented May 10, 2024 •
edited
Loading

We have fixed it in #3920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide component: lsp type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pepeiborra @jneira @michaelpj @soulomoon