Skip to content

Brute-force copy of install.hs from hie #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented Jan 29, 2020

Renamed the string stuff to be "haskell-ide-" instead of "hie-",
nothing else changed.

Initial hand tests show it working for stack installs.

Closes #14

Renamed the string stuff to be "haskell-ide-" instead of "hie-",
nothing else changed.

Initial hand tests show it working for stack installs.

Closes haskell#14
@alanz alanz requested review from jneira and fendor January 29, 2020 21:28
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest simplifying this script significantly, e.g. by dropping dependency on shake, but it can be done in a follow-up PR

@fendor
Copy link
Collaborator

fendor commented Jan 29, 2020

Maybe integrate changes from haskell/haskell-ide-engine#1615?

@jneira
Copy link
Member

jneira commented Jan 29, 2020

Yeah i'll do

@alanz alanz merged commit e5f8c05 into haskell:master Jan 29, 2020
@alanz alanz deleted the 14-install-hs branch January 29, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create build system to make installation easier
3 participants