Skip to content

Disable refinement hole fits #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Jul 26, 2021

Let's review the benchmark results to see how expensive refinement hole fits are in practice. Then we can decide whether to keep them or not

@pepeiborra pepeiborra force-pushed the disable-refinement-hole-fits branch 2 times, most recently from fde449a to b220ebc Compare July 27, 2021 06:39
@pepeiborra pepeiborra force-pushed the disable-refinement-hole-fits branch from b220ebc to b1e0689 Compare July 27, 2021 09:08
@pepeiborra
Copy link
Collaborator Author

Results for the lsp-types example:

upstream   edit                             True      50        1.671270325          0.0           0.6073194759999999    8.608297202000005       9.223011378          202MB          9026MB
HEAD       edit                             True      50        1.305338329          0.0           0.38494863600000007   10.012330334999998      10.402405344         203MB          9072MB
upstream   hole fit suggestions             True      50        1.142132948          0.0           189.604739854         1.9936279e-2            189.630975323        282MB          199790MB
HEAD       hole fit suggestions             True      50        1.890731358          0.0           85.15542919800005     1.9193362999999998e-2   85.181236653         268MB          85096MB

Disabling refinement hole fits improves the total time by 50%. It still takes 9X longer to typecheck than without any holes at all, but I guess this is progress.

@anka-213 what do you think about not enabling refinement holes? Users can always enable them in their cradles.

@Tritlo
Copy link

Tritlo commented Jul 31, 2021

Just a comment: typed-holes (and refinement holes) will become a lot faster soon https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants