Skip to content

CI: cache-deps: rm pull request hook #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2021
Merged

CI: cache-deps: rm pull request hook #2426

merged 3 commits into from
Dec 1, 2021

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Dec 1, 2021 •
edited by gitpod-io bot
Loading

I needed to remove b0621d7 before merge.

That is my fault, I should be more conservative with signaling draft<->mergable PR.

@Anton-Latukha
CI: cache-deps: rm pull request hook
80ae595 
I needed to remove
haskell@b0621d7
before merge.

That is my fault, I should be more conservative between draft<->mergable PR.
@Anton-Latukha Anton-Latukha force-pushed the 2021-12-01-ci-upd-cache branch from 7327d47 to 80ae595 Compare December 1, 2021 13:29
@Anton-Latukha Anton-Latukha changed the title CI: cache-deps: revert pull request hook CI: cache-deps: rm pull request hook Dec 1, 2021
@Anton-Latukha
Copy link
Collaborator Author

Anton-Latukha commented Dec 1, 2021 •
edited
Loading

To be clear: this master cache building workflow is made to run on master only, hook was to test&show inside the PR that & how it works.

Additional thought: Currently test.yml already does almost the exact thing unstably inside the PRs & that is the next thing I wanted to look into. First question - it how to keep master caches intact in the cache pool (are they stay intact). The easiest effective solution there is to prevent PRs from saving cache, so they would be required to follow master to have the cache. But I also wanted to look is it possible to at the same time give PRs some ability to additionally cache their build artifacts during active work.

@Anton-Latukha
CI: cache-deps: shift cache regeneration time
bcfbde9 
Since most contributors are in the US & EU, & lets pretend they contribute
between 17:00 - 00:30 - this cache time seems better.
@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 1, 2021 14:18
jneira
jneira approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont worry, i saw the comment when the pr was a draft and i did not a proper review once it was marked as ready to review
no final user was harmed in the process so 🤷

@jneira jneira merged commit 3e44c70 into haskell:master Dec 1, 2021
drsooch pushed a commit to drsooch/haskell-language-server that referenced this pull request Dec 3, 2021
@Anton-Latukha @drsooch
CI: cache-deps: rm pull request hook (haskell#2426)
fba1820 
* CI: cache-deps: rm pull request hook

I needed to remove
haskell@b0621d7
before merge.

That is my fault, I should be more conservative between draft<->mergable PR.

* CI: cache-deps: shift cache regeneration time

Since most contributors are in the US & EU, & lets pretend they contribute
between 17:00 - 00:30 - this cache time seems better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anton-Latukha @jneira