Lockless FileExistsMap and position mapping #2442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Dec 6, 2021
| Succeeded ver (fromDynamic -> Just v) -> pure (Just (v, mappingForVersion allMappings file ver)) | ||
| Stale del ver (fromDynamic -> Just v) -> pure (Just (v, maybe id addDelta del $ mappingForVersion allMappings file ver)) | ||
| Succeeded ver (fromDynamic -> Just v) -> | ||
| atomically $ Just . (v,) <$> mappingForVersion positionMapping file ver |
There was a problem hiding this comment.
Just use one transaction including these and the stuff on line 358? Hm, maybe readPersistent gets in the way...
| @@ -328,7 +328,6 @@ getIdeOptionsIO ide = do | |||
| -- for the version of that value. | |||
| lastValueIO :: IdeRule k v => ShakeExtras -> k -> NormalizedFilePath -> IO (Maybe (v, PositionMapping)) | |||
There was a problem hiding this comment.
Interestingly, I think this entire function is close to being in STM. Maybe just persistentKeys blocking it. Not sure if that's desirable.
There was a problem hiding this comment.
I think this one is firmly in IO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5th instalment from #2357